[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v12 0/4] qapi: Allow modularization of QAPI sche

From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH v12 0/4] qapi: Allow modularization of QAPI schema files
Date: Tue, 06 May 2014 09:02:31 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0

On 05/06/2014 07:07 AM, Benoît Canet wrote:
> common.json being included in block-core.json and in qapi-schema.json it
> quickly lead some code being generated in double and the compilation to choke.
> What do you think would be the best solution to fix this ?
> (Fix the generator ? Make include ignore second inclusion of the same file ?)

I'd argue for the latter - update the parser and the documentation to
state that if a file is included twice, the second inclusion does
nothing. Obviously, the testsuite needs enhancement to test the
solution, as well.

Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]