[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 00/14] qmp qga: Purge error_is_set()
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH v3 00/14] qmp qga: Purge error_is_set() |
Date: |
Wed, 07 May 2014 18:00:39 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux) |
Luiz Capitulino <address@hidden> writes:
> On Fri, 2 May 2014 13:26:28 +0200
> Markus Armbruster <address@hidden> wrote:
>
>> I got a private branch getting rid of it entirely. This is the fifth
>> part, covering QMP and the guest agent up to the point where I start
>> messing with the QAPI code generators. That's left for the final
>> part.
>>
>> Luiz agreed to take this through his tree.
>>
>> This series conflicts with LluĂs's "qapi: Allow modularization of QAPI
>> schema files", but only in docs/writing-qmp-commands.txt, and
>> resolution is trivial.
>
> I didn't get any conflicts.
Even better :)
> Have you looked at Laszlo series to make sure it follows your guidelines?
>
> http://lists.nongnu.org/archive/html/qemu-devel/2014-04/msg01506.html
Looks fine to me at a glance: no new error_is_set(), all Error * and
Error ** variables are nicely named.
> I've already applied his series to my tree, btw. Yours is on top.
>
> Applied to the qmp branch, thanks.
Thanks!
- [Qemu-devel] [PATCH v3 07/14] qapi: Drop redundant, unclean error_is_set(), (continued)
- [Qemu-devel] [PATCH v3 07/14] qapi: Drop redundant, unclean error_is_set(), Markus Armbruster, 2014/05/02
- [Qemu-devel] [PATCH v3 08/14] tests/qapi-schema: Drop superfluous error_is_set(), Markus Armbruster, 2014/05/02
- [Qemu-devel] [PATCH v3 13/14] dump: Drop pointless error_is_set(), DumpState member errp, Markus Armbruster, 2014/05/02
- [Qemu-devel] [PATCH v3 09/14] qapi: Clean up fragile use of error_is_set(), Markus Armbruster, 2014/05/02
- [Qemu-devel] [PATCH v3 06/14] hmp: Guard against misuse of hmp_handle_error(), Markus Armbruster, 2014/05/02
- [Qemu-devel] [PATCH v3 11/14] qga: Drop superfluous error_is_set(), Markus Armbruster, 2014/05/02
- [Qemu-devel] [PATCH v3 01/14] qmp hmp: Consistently name Error * objects err, and not errp, Markus Armbruster, 2014/05/02
- [Qemu-devel] [PATCH v3 05/14] qga: Use return values instead of error_is_set(errp), Markus Armbruster, 2014/05/02
- Re: [Qemu-devel] [PATCH v3 00/14] qmp qga: Purge error_is_set(), Eric Blake, 2014/05/02
- Re: [Qemu-devel] [PATCH v3 00/14] qmp qga: Purge error_is_set(), Luiz Capitulino, 2014/05/07
- Re: [Qemu-devel] [PATCH v3 00/14] qmp qga: Purge error_is_set(),
Markus Armbruster <=