[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/2] build: more libcacard cleanups
|
From: |
Michael Tokarev |
|
Subject: |
Re: [Qemu-devel] [PATCH 2/2] build: more libcacard cleanups |
|
Date: |
Thu, 08 May 2014 17:33:33 +0400 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Icedove/24.5.0 |
08.05.2014 17:28, Paolo Bonzini wrote:
> Il 08/05/2014 15:16, Michael Tokarev ha scritto:
>> However, I still (in combined result of the 2 patches) miss one little detail
>> about libcacard and this stuff, which this patch also does a bit wrong.
>>
>> $(NSS_LIBS) is not a dependency of hw/usb/ccid-card-emulated.o, it is a
>> dependency of libcacard/vcard_emul_nss.o - the only single file in whole
>> qemu tree which actually uses nss stuff. Hopefully, it works after the
>> per-object -libs fixup patch.. ;)
>
> You're obviously right and yes, it works giving this overall patch:
The same as I commited a few mins ago. But with a fixme for now
in vcard_emul_nss.o-libs place (as I need to keep it working in
my tree too).
http://git.corpit.ru/?p=qemu.git;a=shortlog;h=refs/heads/mjt-buildsys-libs
Thanks,
/mjt