[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 09/10] build: simplify and fix fix-obj-vars

From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH 09/10] build: simplify and fix fix-obj-vars
Date: Thu, 08 May 2014 16:30:04 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0

Il 08/05/2014 15:53, Michael Tokarev ha scritto:
08.05.2014 17:36, Paolo Bonzini wrote:
fix-obj-vars has the undesired side effect of breaking -cflags
-objs and -libs variables in the toplevel Makefile.objs.  The
variables in the toplevel Makefile.objs do not need any fix,
so fix-obj-vars need not do anything.

@@ -228,7 +229,7 @@ endef
 define unnest-vars
 $(eval obj := $1)
 $(eval nested-vars := $2)
-$(foreach v,$(nested-vars),$(call fix-obj-vars,$v,$(if $(obj),$(obj)/)))
+$(foreach v,$(nested-vars),$(call fix-obj-vars,$v,$(obj)))
 $(eval old-nested-dirs := )
 $(call unnest-vars-1)
 $(if $1,$(foreach v,$(nested-vars),$(eval \

How about ditching 01/10 and replacing it with this 09/10 ?

I was thinking about that, but in the end the two fixes are different, and given the code is tricky, small patches are preferrable.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]