[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] Update QEMU checkpatch.pl to current linux vers
Re: [Qemu-devel] [PATCH] Update QEMU checkpatch.pl to current linux version
Thu, 8 May 2014 11:22:31 -0400
On Thu, May 8, 2014 at 10:02 AM, Peter Maydell <address@hidden> wrote:
>>> total: 0 errors, 0 warnings, 79 lines checked
>>> /tmp/a has no obvious style problems and is ready for submission.
>>> Check 500, Bad 52
>> How does your new checkpatch compare to our current one?
> Yes; we do sometimes let checkpatch-failing commits through,
> so it would be more interesting to know:
> * how many commits passed old-checkpatch but fail the new one
> * how many commits failed with old-checkpatch but pass now
> * in both cases, how many of the failures are false positives?
> (the last of those is tricky to answer without eyeballing
> the errors, unfortunately)
That seems like a good test regime and not a lot of effort using the
bash script Don shared.
There appears to be some interest in this patch. I'll work on a 2nd
revision, following Peter's suggestion to separate the QEMU rules into
a separate, smaller patch (and with the correct handling of brackets).