[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] spice: return unspecified address according to
|
From: |
Amos Kong |
|
Subject: |
Re: [Qemu-devel] [PATCH] spice: return unspecified address according to protocol |
|
Date: |
Mon, 12 May 2014 18:06:28 +0800 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Mon, May 12, 2014 at 11:34:18AM +0200, Gerd Hoffmann wrote:
> Hi,
>
> > info->has_host = true;
> > - info->host = g_strdup(addr ? addr : "*");
> > + info->host = g_strdup(addr ? addr : (qemu_opt_get_bool(opts,
> > + "ipv6", 0)
> > + ? "::" : "0.0.0.0"));
>
> "ipv6" means "force ipv6". If the option is not present spice-server
> might still listen on ipv6, and qemu can't easily figure whenever that
> is the case or not.
OK. And management will not use this returned address, so it's
not a serious issue.
Thanks. NAK this patch.
> cheers,
> Gerd
>
>
--
Amos.