[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH 08/11] softmmu: make do_unaligned_access ext
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [RFC PATCH 08/11] softmmu: make do_unaligned_access extern |
Date: |
Tue, 13 May 2014 08:53:48 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 |
Am 08.05.2014 18:09, schrieb Paolo Bonzini:
> We will reference it from more files in the next patch.
>
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
> target-alpha/cpu.h | 3 +++
> target-alpha/mem_helper.c | 4 ++--
> target-mips/cpu.h | 3 +++
> target-mips/op_helper.c | 8 ++------
> target-sparc/cpu.h | 4 ++++
> target-sparc/ldst_helper.c | 9 +++------
> target-xtensa/cpu.h | 3 +++
> target-xtensa/op_helper.c | 5 +----
> 8 files changed, 21 insertions(+), 18 deletions(-)
>
> diff --git a/target-alpha/cpu.h b/target-alpha/cpu.h
> index d9b861f..242068f 100644
> --- a/target-alpha/cpu.h
> +++ b/target-alpha/cpu.h
> @@ -498,6 +498,9 @@ static inline void cpu_get_tb_cpu_state(CPUAlphaState
> *env, target_ulong *pc,
> *pflags = flags;
> }
>
> +void do_unaligned_access(CPUAlphaState *env, target_ulong addr,
> + int is_write, int is_user, uintptr_t retaddr);
> +
> #include "exec/exec-all.h"
>
> #endif /* !defined (__CPU_ALPHA_H__) */
[snip]
Have you considered turning this into CPUClass hooks instead, as done
with do_unassigned_access?
Before your patch, this was a static function used only by
softmmu_template.h - making it global is not exactly helping with
multi-target support. Any solution to remedy regressions appreciated.
Regards,
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
- Re: [Qemu-devel] [RFC PATCH 01/11] hw: use ld_p/st_p instead of ld_raw/st_raw, (continued)
- [Qemu-devel] [RFC PATCH 11/11] softmmu: move all load/store functions to cpu_ldst.h, Paolo Bonzini, 2014/05/08
- [Qemu-devel] [RFC PATCH 09/11] target-arm: move arm_*_code to a separate file, Paolo Bonzini, 2014/05/08
- [Qemu-devel] [RFC PATCH 05/11] softmmu: move ALIGNED_ONLY to cpu.h, Paolo Bonzini, 2014/05/08
- [Qemu-devel] [RFC PATCH 04/11] softmmu: move definition of CPU_MMU_INDEX to inclusion site, drop ACCESS_TYPE, Paolo Bonzini, 2014/05/08
- [Qemu-devel] [RFC PATCH 02/11] softmmu: start introducing SOFTMMU_CODE_ACCESS in softmmu_header.h, Paolo Bonzini, 2014/05/08
- [Qemu-devel] [RFC PATCH 08/11] softmmu: make do_unaligned_access extern, Paolo Bonzini, 2014/05/08
- Re: [Qemu-devel] [RFC PATCH 08/11] softmmu: make do_unaligned_access extern,
Andreas Färber <=
- [Qemu-devel] [RFC PATCH 03/11] softmmu: move MMUSUFFIX under SOFTMMU_CODE_ACCESS, Paolo Bonzini, 2014/05/08
- [Qemu-devel] [RFC PATCH 07/11] softmmu: move softmmu_template.h out of include/, Paolo Bonzini, 2014/05/08
- [Qemu-devel] [RFC PATCH 10/11] softmmu: introduce cpu_ldst.h, Paolo Bonzini, 2014/05/08
- [Qemu-devel] [RFC PATCH 06/11] softmmu: commonize helper definitions, Paolo Bonzini, 2014/05/08
- Re: [Qemu-devel] [RFC PATCH 00/11] Cleanup load/store functions in headers and C files, Richard Henderson, 2014/05/12