[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 04/10] tcg: Use helper-gen.h in tcg-op.h

From: Richard Henderson
Subject: Re: [Qemu-devel] [PATCH 04/10] tcg: Use helper-gen.h in tcg-op.h
Date: Tue, 13 May 2014 06:44:38 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0

On 05/13/2014 02:34 AM, Alex Bennée wrote:
> I'm having trouble figuring out what the sizemask stuff was trying to
> achieve and if it's required/covered after the change. Is the final
> helper now the one defined as?
> DEF(div_i32, 1, 2, 0, IMPL(TCG_TARGET_HAS_div_i32))
> it's hard to follow the parameters of this compared to the target
> helpers where the the argument sizes are a lot more explicit.

The sizemask stuff is about encoding the argument types of the function.

What you've quoted above is not the helper, but the TCG opcode.
The helper is defined as

DEF_HELPER_FLAGS_2(div_i32, TCG_CALL_NO_RWG_SE, s32, s32, s32)

in the previous patch.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]