Re: [Qemu-devel] [PATCH] qemu-img: sort block formats in help message

[Kevin Wolf]

Am 13.05.2014 um 18:07 hat Mike Day geschrieben:
> The help message for qemu-img lists the supported block formats, of
> which there are 27 as of version 2.0.50. The formats are printed in
> the order of their driver's position in a linked list, which appears
> random. This patch prints the formats in sorted order, making it
> easier to read and to find a specific format in the list.
> 
> [Added suggestions from Fam Zheng <address@hidden> to declare variables
> at the top of the scope in help() and to omit explicit cast for void*
> opaque.
> --Stefan]
> 
> [Removed call to g_sequence_lookup because it breaks the build on
>  machines with glib < 2.28.
> --Mike]
> 
> Signed-off-by: Mike Day <address@hidden>
> Signed-off-by: Stefan Hajnoczi <address@hidden>

What happened here? This patch seems to be already applied, and you
included Stefan's SoB as well.

Kevin