[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 3/4] vl.c: do not set 'type' property in obj_set

From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH 3/4] vl.c: do not set 'type' property in obj_set_property
Date: Thu, 15 May 2014 19:13:25 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0

Il 15/05/2014 18:38, Andreas Färber ha scritto:
On that matter, our help output does not seem to indicate the name of
the corresponding -object parameter, my unverified guess is that that is
called "qom-type".

OTOH there's no reason to suppress "qom-type" or "id" for -machine, as
implied when I suggested using a separate function.

"id" should be suppressed for backwards compatibility for "-machine id=foo".

"qom-type" is not needed indeed. But it is so ugly that I would suggest doing a backwards-incompatible change to the name the default argument of -object, from "qom-type" to "type". Libvirt doesn't use "qom-type", and "type" nicely matches the QOM property name:

  $ qemu-system-x86_64 -qmp unix:/tmp/m1,server,nowait -S \
       -object rng-random,id=foo &
  $ ./qom-get -s /tmp/m1 /objects/foo.type


reply via email to

[Prev in Thread] Current Thread [Next in Thread]