[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] Remove g_sequence_lookup from qemu-img help fun

From: Alexander Graf
Subject: Re: [Qemu-devel] [PATCH] Remove g_sequence_lookup from qemu-img help function
Date: Fri, 16 May 2014 14:35:53 +0200
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:24.0) Gecko/20100101 Thunderbird/24.5.0

On 14.05.14 10:23, Peter Maydell wrote:
On 14 May 2014 08:44, Kevin Wolf <address@hidden> wrote:
Am 13.05.2014 um 23:48 hat Eric Blake geschrieben:
On 05/13/2014 03:11 PM, Mike Day wrote:

Subject line could have used a [PATCHv2] designation to make it obvious
this is a fixed version.  But that doesn't affect what goes into git.

g_sequence_lookup is not supported by glib < 2.28. The usage
of g_sequence_lookup is not essential in this context (it's a
safeguard against duplicate values in the help message).
Removing the call enables the build on all platforms and
does not change the operation of the help function.

Signed-off-by: Mike Day <address@hidden>
  qemu-img.c | 7 ++-----
  1 file changed, 2 insertions(+), 5 deletions(-)
Reviewed-by: Eric Blake <address@hidden>
Thanks, applied to the block branch.
Ah, I was thinking about applying this directly since it's a build fix.
But I guess it could go through the block branch instead...

Yes, could you please apply it directly?


reply via email to

[Prev in Thread] Current Thread [Next in Thread]