[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 12/16] sd: Convert debug printfs to QEMU_DPRI
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v3 12/16] sd: Convert debug printfs to QEMU_DPRINTF |
Date: |
Mon, 19 May 2014 15:05:57 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 |
On 05/17/2014 05:03 PM, Marc Marí wrote:
> Modify debug macros to have the same format through the codebase and use
> regular
> ifs instead of ifdef.
>
> Signed-off-by: Marc Marí <address@hidden>
> ---
> hw/sd/sd.c | 8 +++++---
> hw/sd/ssi-sd.c | 19 ++++++++++++-------
> 2 files changed, 17 insertions(+), 10 deletions(-)
>
> +#define DPRINTF(fmt, ...) \
> + QEMU_DPRINTF(DEBUG_SSI_SD_ENABLED, "ssi_sd", fmt, ## __VA_ARGS__)
> +#define BADF(fmt, ...) \
> + do { \
> + QEMU_DPRINTF(1, "ssi_sd error", fmt, ## __VA_ARGS__); \
> + if(DEBUG_SSI_SD_ENABLED) { \
Style: space after 'if'
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH v3 03/16] s390: Convert debug printfs to QEMU_DPRINTF, (continued)
- [Qemu-devel] [PATCH v3 07/16] spapr: Convert debug printfs to QEMU_DPRINTF, Marc Marí, 2014/05/17
- [Qemu-devel] [PATCH v3 04/16] scsi: Convert debug printfs to QEMU_DPRINTF, Marc Marí, 2014/05/17
- [Qemu-devel] [PATCH v3 05/16] highbank: Convert debug printfs to QEMU_DPRINTF, Marc Marí, 2014/05/17
- [Qemu-devel] [PATCH v3 06/16] xilinx: Convert debug printfs to QEMU_DPRINTF, Marc Marí, 2014/05/17
- [Qemu-devel] [PATCH v3 09/16] i82374: Convert debug printfs to QEMU_DPRINTF, Marc Marí, 2014/05/17
- [Qemu-devel] [PATCH v3 08/16] stellaris: Convert debug printfs to QEMU_DPRINTF, Marc Marí, 2014/05/17
- [Qemu-devel] [PATCH v3 10/16] i8257: Convert debug printfs to QEMU_DPRINTF, Marc Marí, 2014/05/17
- [Qemu-devel] [PATCH v3 11/16] rc4030: Convert debug printfs to QEMU_DPRINTF, Marc Marí, 2014/05/17
- [Qemu-devel] [PATCH v3 12/16] sd: Convert debug printfs to QEMU_DPRINTF, Marc Marí, 2014/05/17
- Re: [Qemu-devel] [PATCH v3 12/16] sd: Convert debug printfs to QEMU_DPRINTF,
Eric Blake <=
- [Qemu-devel] [PATCH v3 13/16] isa: Convert debug printfs to QEMU_DPRINTF, Marc Marí, 2014/05/17
- [Qemu-devel] [PATCH v3 14/16] lan9118: Convert debug printfs to QEMU_DPRINTF, Marc Marí, 2014/05/17
- [Qemu-devel] [PATCH v3 16/16] common: Convert debug printfs to QEMU_DPRINTF, Marc Marí, 2014/05/17
- [Qemu-devel] [PATCH v3 15/16] pci-host: Convert debug printfs to QEMU_DPRINTF, Marc Marí, 2014/05/17