Re: [Qemu-devel] [PATCH 0/7] cleanups for compressed dumps (kdumps)

[Laszlo Ersek]

On 05/20/14 14:56, Paolo Bonzini wrote:
> Il 20/05/2014 13:39, Laszlo Ersek ha scritto:
>> In March Paolo and Luiz had some comments for upstream qemu while they
>> were reviewing my downstream port of Qiao Nuohan's compressed
>> (kdump-format) dump feature. I've finally got around addressing them.
>>
>> Laszlo Ersek (7):
>>   dump: fill in the flat header signature more pleasingly to the eye
>>   dump: simplify write_start_flat_header()
>>   dump: eliminate DumpState.page_shift ("guest's page shift")
>>   dump: eliminate DumpState.page_size ("guest's page size")
>>   dump: select header bitness based on ELF class, not ELF architecture
>>   dump: hoist lzo_init() from get_len_buf_out() to dump_init()
>>   dump: simplify get_len_buf_out()
>>
>>  include/sysemu/dump.h |   8 +--
>>  dump.c                | 142
>> ++++++++++++++++++++++----------------------------
>>  2 files changed, 65 insertions(+), 85 deletions(-)
>>
> 
> I would have a slight preference for QEMU_BUILD_BUG_ON instead of MIN in
> patch 1, but that's a really minor nit.
> 
> Reviewed-by: Paolo Bonzini <address@hidden>

Thanks! Should I have to respin for any reason, I'll incorporate your
suggestion.

Laszlo