[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v20 06/15] block: Add backing_blocker in BlockDr

From: Stefan Hajnoczi
Subject: Re: [Qemu-devel] [PATCH v20 06/15] block: Add backing_blocker in BlockDriverState
Date: Wed, 21 May 2014 16:06:38 +0200
User-agent: Mutt/1.5.23 (2014-03-12)

On Tue, May 20, 2014 at 02:04:31PM +0800, Fam Zheng wrote:
> This makes use of op_blocker and blocks all the operations except for
> commit target, on each BlockDriverState->backing_hd.
> The asserts for op_blocker in bdrv_swap are removed because with this
> change, the target of block commit has at least the backing blocker of
> its child, so the assertion is not true. Callers should do their check.
> Signed-off-by: Fam Zheng <address@hidden>
> ---
>  block.c                   | 22 ++++++++++++++++++----
>  block/mirror.c            |  1 +
>  include/block/block_int.h |  3 +++
>  3 files changed, 22 insertions(+), 4 deletions(-)

IMO it would be nice to split the series after this patch.

The op_blocker stuff looks solid and the series is at v20.  Let's handle
the rest of the changes in separate, smaller series that can be easily


reply via email to

[Prev in Thread] Current Thread [Next in Thread]