[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2 1/7] libcacard/vscclient: Bury some dead code
From: |
Markus Armbruster |
Subject: |
[Qemu-devel] [PATCH v2 1/7] libcacard/vscclient: Bury some dead code |
Date: |
Fri, 23 May 2014 13:24:33 +0200 |
Spotted by Coverity.
Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Alon Levy <address@hidden>
---
libcacard/vscclient.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/libcacard/vscclient.c b/libcacard/vscclient.c
index 3477ab3..29f4958 100644
--- a/libcacard/vscclient.c
+++ b/libcacard/vscclient.c
@@ -502,8 +502,7 @@ do_command(GIOChannel *source,
if (reader != NULL) {
error = vcard_emul_force_card_insert(reader);
printf("insert %s, returned %d\n",
- reader ? vreader_get_name(reader)
- : "invalid reader", error);
+ vreader_get_name(reader), error);
} else {
printf("no reader by id %u found\n", reader_id);
}
@@ -515,8 +514,7 @@ do_command(GIOChannel *source,
if (reader != NULL) {
error = vcard_emul_force_card_remove(reader);
printf("remove %s, returned %d\n",
- reader ? vreader_get_name(reader)
- : "invalid reader", error);
+ vreader_get_name(reader), error);
} else {
printf("no reader by id %u found\n", reader_id);
}
--
1.9.0
- [Qemu-devel] [PATCH v2 0/7] libcacard: A few simple fixes and cleanups, Markus Armbruster, 2014/05/23
- [Qemu-devel] [PATCH v2 2/7] libcacard: Plug memory leaks around vreader_get_reader_list(), Markus Armbruster, 2014/05/23
- [Qemu-devel] [PATCH v2 3/7] libcacard/vreader: Drop broken recovery from failed assertion, Markus Armbruster, 2014/05/23
- [Qemu-devel] [PATCH v2 7/7] libcacard/vcard_emul_nss: Drop a redundant conditional, Markus Armbruster, 2014/05/23
- [Qemu-devel] [PATCH v2 1/7] libcacard/vscclient: Bury some dead code,
Markus Armbruster <=
- [Qemu-devel] [PATCH v2 4/7] libcacard/vreader: Tighten assertion to clarify intent, Markus Armbruster, 2014/05/23
- Re: [Qemu-devel] [PATCH v2 0/7] libcacard: A few simple fixes and cleanups, Michael Tokarev, 2014/05/23