[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/4] Makefile: Link vscclient with libqemuutil.a
Re: [Qemu-devel] [PATCH 1/4] Makefile: Link vscclient with libqemuutil.a and libqemustub.a
Fri, 23 May 2014 13:33:22 +0200
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0
Il 23/05/2014 11:36, Michael Tokarev ha scritto:
Here's the last incarnation:
The prob was re-defining GCond to GCond* in the _thin_ compat
layer I wanted to add for _old_ glib (so that all the code uses
new glib api, because that's what people know now). That one
is fun indeed, but it allows us to go without inventing a thick
layer which will just complicate things and add unnecessary and
qemu-specific API -- to me it is too much cost for supporting
obsolete glib thread api.
FWIW, the old glib thread api is a frozen code, so we shouldn't
expect any changes in there. And my changes does not wrap new
api (except of adding tiny wrappers for static initializers).
I liked your approach, but at the same time there is a problem: It would
break completely any API that includes GMutex/GCond. GTK itself exposes
a GMutex when you use gtk/gtk.h.
We can exploit the macro vs. inline function difference to our
advantage, to keep the wrapper small (just
s/GMutex/CompatGMutex/;s/GCond/CompatGCond/) and also type safe.
I'll post my version in a second.
[Qemu-devel] [PATCH 2/4] Makefile: Compile libqemustub.a and libqemuutil.a with -fPIC, Fam Zheng, 2014/05/22
[Qemu-devel] [PATCH 3/4] rules.mak: Link DSO with libqemuutil.a, Fam Zheng, 2014/05/22
[Qemu-devel] [PATCH 4/4] .travis.yml: Add a new build target with --enable-modules, Fam Zheng, 2014/05/22
Re: [Qemu-devel] [PATCH 0/4] buildsys: Fix module build for block-iscsi.so, Michael Tokarev, 2014/05/23
Re: [Qemu-devel] [PATCH 0/4] buildsys: Fix module build for block-iscsi.so, Paolo Bonzini, 2014/05/23