Re: [Qemu-devel] [PATCH v3 3/7] iotests: Add default common.env

[Markus Armbruster]

Eric Blake <address@hidden> writes:

> On 05/23/2014 12:10 AM, Fam Zheng wrote:
>> On Thu, 05/22 23:30, Max Reitz wrote:
>>> Add a default common.env in case the one supposed to be emitted by
>>> configure cannot be found.
>>>
>>> Signed-off-by: Max Reitz <address@hidden>
>> 
>> Now we can run both from in-tree build and out-of-tree build without this,
>> which is already very good, but we need this patch to run from the source 
>> tree
>> with an out-of-tree build. I'm not sure we really need that, though.
>
> If you have a source tree but no in-tree build, then there is no way to
> know how many out-of-tree builds there are, or which one you should
> pick.  If you are going to do out-of-tree builds, you aren't going to
> try to run tests from the source tree.

Let's not try to guess a build tree.

If someone tries to run tests in the source tree, and the source tree
has not been made a build tree by running configure there, simply fail.