[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] arm: Bugfix: Fix cpu_reset() / vcpu_init() orde

From: Peter Maydell
Subject: Re: [Qemu-devel] [PATCH] arm: Bugfix: Fix cpu_reset() / vcpu_init() order
Date: Tue, 27 May 2014 13:12:08 +0100

On 27 May 2014 12:24, Christoffer Dall <address@hidden> wrote:
> This fix a bug introduced by commit
> 50a2c6e55fa2ce5a2916a2c206bad2c6b0e06df1, but I'm not sure it is a
> proper fix.

This commit message could use being beefed up a bit.
(I tend to recommend that commentary like "not sure
this is right" goes below the '---'.)

target-arm: Fix segfault on startup when KVM enabled

Commit 50a2c6e55fa introduced a bug where QEMU would
segfault on startup when using KVM on ARM hosts, because
kvm_arm_reset_cpu() accesses cpu->cpreg_reset_values, which
is not allocated before kvm_arch_init_vcpu(). Fix this
by not calling cpu_reset() until after qemu_init_vcpu().

> Acked-by: Paolo Bonzini <address@hidden>
> Signed-off-by: Christoffer Dall <address@hidden>

Reviewed-by: Peter Maydell <address@hidden>

-- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]