Re: [Qemu-devel] [RFC PATCH 2/4] icount: Make icount_time_shift available everywhere

[Sebastian Tanase]

----- Mail original -----
> De: "Juan Quintela" <address@hidden>
> À: "Sebastian Tanase" <address@hidden>
> Cc: address@hidden, address@hidden, address@hidden, address@hidden, "peter 
> maydell"
> <address@hidden>, address@hidden, address@hidden, address@hidden, 
> address@hidden,
> address@hidden, address@hidden, address@hidden
> Envoyé: Mercredi 28 Mai 2014 11:11:32
> Objet: Re: [RFC PATCH 2/4] icount: Make icount_time_shift available everywhere
> 
> Sebastian Tanase <address@hidden> wrote:
> > icount_time_shift is used for calculting the delay
> > qemu has to sleep in order to synchronise the
> > host and guest clocks. Therefore, we need it in
> > cpu-exec.c.
> >
> > Signed-off-by: Sebastian Tanase <address@hidden>
> > Tested-by: Camille Bégué <address@hidden>
> 
> ....
> 
> > @@ -454,6 +458,8 @@ void configure_icount(const char *option)
> >          return;
> >      }
> >  
> > +    /* Do not activate align with icount auto, for now */
> > +    icount_align_option = 0;
> >      use_icount = 2;
> >  
> >      /* 125MIPS seems a reasonable initial guess at the guest
> >      speed.
> 
> Why is this hunk on this patch?  If needed, add it to the commit
> message?
> 
> Thanks, Juan.
> 
> 

Hello, 

You are right, it should be on the first patch. I will fix this.

Thank you for your feedback.

Regards,

Sebastian Tanase

Open Wide Ingenierie
23, rue Daviel
75013 Paris - France
www.openwide.fr