|
From: | Paolo Bonzini |
Subject: | Re: [Qemu-devel] [PATCH 07/13] softmmu: make do_unaligned_access a method of CPU |
Date: | Wed, 28 May 2014 20:47:48 +0200 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 |
Il 28/05/2014 20:24, Andreas Färber ha scritto:
>>> +void alpha_cpu_do_unaligned_access(CPUState *cs, vaddr addr, >>> + int is_write, int is_user, >>> uintptr_t retaddr) >>> { >>> - AlphaCPU *cpu = alpha_env_get_cpu(env); >>> - CPUState *cs = CPU(cpu); >>> + AlphaCPU *cpu = ALPHA_CPU(cs);> > What's the standard variable name for XyzCPU?"cpu", no objections there. The assumption is that the specific type will be used more often and should thus have the more natural name.
How do I make the argument "CPUState *cpu" if I then have to assign it to "AlphaCPU *cpu"? :)
Paolo
[Prev in Thread] | Current Thread | [Next in Thread] |