qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] block/iscsi: handle BUSY condition


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH] block/iscsi: handle BUSY condition
Date: Fri, 30 May 2014 07:50:42 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0

Il 29/05/2014 22:25, Peter Lieven ha scritto:
Am 29.05.2014 21:17, schrieb Paolo Bonzini:
Il 29/05/2014 20:41, Peter Lieven ha scritto:
static inline unsigned geo_rand_range(double m, double n) {
    return exp((log(m) + (double)rand() /
               (RAND_MAX / (log(n) - log(m) + log(1)) + log(1))));
}

Yes, exactly (except that log(1) is zero, and was only needed in your case 
because you were using integers).

Regarding aio_timer_new vs. aio_timer_init. Shall we really have the complete 
QEMU_TIMER struct in each
iTask? We need this retry_timer only in the really rare case of a BUSY.

Ok, makes sense. Though the overall cost of IscsiTasks should be less than 4k per block device with a separate QemuTimer, and 8k if you embed it.

Otherwise the patch looks good, thanks!

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]