[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC 2/5] acpi: introduce TYPE_ACPI_DEVICE_IF interface
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [RFC 2/5] acpi: introduce TYPE_ACPI_DEVICE_IF interface |
Date: |
Fri, 30 May 2014 09:19:04 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 |
On 05/28/2014 08:57 AM, Igor Mammedov wrote:
> ... it will be used to abstract generic ACPI bits from
> device that implements ACPI interface.
>
> Signed-off-by: Igor Mammedov <address@hidden>
> ---
> hw/acpi/Makefile.objs | 1 +
> hw/acpi/acpi_interface.c | 15 ++++++++++++
> include/hw/acpi/acpi_dev_interface.h | 43
> ++++++++++++++++++++++++++++++++++
> qapi-schema.json | 18 ++++++++++++++
> 4 files changed, 77 insertions(+), 0 deletions(-)
> create mode 100644 hw/acpi/acpi_interface.c
> create mode 100644 include/hw/acpi/acpi_dev_interface.h
>
Just an interface review...
> +++ b/qapi-schema.json
> @@ -4775,3 +4775,21 @@
> # Since: 2.1
> ##
> { 'command': 'query-memory-devices', 'returns': ['MemoryDeviceInfo'] }
> +
> +## @ACPIOSTInfo
> +#
> +# OSPM Status Indication for a device
> +# possible values are as desribed in "_OST (OSPM Status Indication)"
s/desribed/described/
> +# chapter, decribing method _OST in ACPI spec.
s/decribing/describing/
> +#
> +# @source_event: Arg0 - An Integer containing the source event
> +#
> +# @status_code: Arg1 – An Integer containing the status code
Why '-' (ASCII) vs. '–' (UTF-8) between the two lines? We generally
stick to ASCII in this file.
s/_/-/ in new QAPI additions.
These docs do not match...
> +#
> +# Since: 2.1
> +##
> +{ 'type': 'ACPIOSTInfo',
> + 'data' : { 'device': 'str',
> + 'source': 'int',
> + 'status': 'int',
> + 'slot': 'int' } }
...this type declaration. I have no idea which one of the two is wrong.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
[Qemu-devel] [RFC 2/5] acpi: introduce TYPE_ACPI_DEVICE_IF interface, Igor Mammedov, 2014/05/28
- Re: [Qemu-devel] [RFC 2/5] acpi: introduce TYPE_ACPI_DEVICE_IF interface,
Eric Blake <=
[Qemu-devel] [RFC 3/5] acpi: implement ospm_status() method for PIIX4/ICH9_LPC devices, Igor Mammedov, 2014/05/28
[Qemu-devel] [RFC 4/5] qmp: add query-acpi-ospm-status command, Igor Mammedov, 2014/05/28
[Qemu-devel] [RFC 5/5] qmp: add ACPI_DEVICE_OST event handling, Igor Mammedov, 2014/05/28