[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v3 03/12] block: Add overlay BDS pointer into th

From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH v3 03/12] block: Add overlay BDS pointer into the BlockDriverState struct
Date: Fri, 30 May 2014 11:40:40 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0

On 05/30/2014 11:35 AM, Jeff Cody wrote:
> Now that node-names can reference an individual BlockDriverState without
> needing to navigate downwards from the 'device' level, in order to find
> the top-most image (active layer) we need a pointer to the overlay of a
> BDS.
> This will allow QMP commands to reference an image solely by its
> node-name, without also needing to pass in the corresponding 'device'
> string.
> This also adds a helper function to set the overlay pointer that is, for
> now, trivial.  But since we recently moved away from open coding
> bs->backing_hd assignment, we should probably also refrain from setting
> bs->overlay directly.
> Signed-off-by: Jeff Cody <address@hidden>
> ---
>  block.c                   | 14 ++++++++++++++
>  include/block/block.h     |  1 +
>  include/block/block_int.h |  1 +
>  3 files changed, 16 insertions(+)

Still a side conversation happening on the non-patch version of this
thread, but just to make sure it isn't lost,

Reviewed-by: Eric Blake <address@hidden>

Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]