[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH memory v4 03/10] qom: object: Ignore refs/unrefs of
From: |
Peter Crosthwaite |
Subject: |
[Qemu-devel] [PATCH memory v4 03/10] qom: object: Ignore refs/unrefs of NULL |
Date: |
Thu, 5 Jun 2014 23:13:36 -0700 |
Just do nothing if passed NULL for a ref or unref. This avoids
call sites that manage a combination of NULL or non-NULL pointers
having to add iffery around every ref and unref.
Signed-off-by: Peter Crosthwaite <address@hidden>
---
qom/object.c | 14 ++++++++------
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/qom/object.c b/qom/object.c
index 956d1ab..6813aba 100644
--- a/qom/object.c
+++ b/qom/object.c
@@ -709,11 +709,17 @@ GSList *object_class_get_list(const char *implements_type,
void object_ref(Object *obj)
{
+ if (!obj) {
+ return;
+ }
atomic_inc(&obj->ref);
}
void object_unref(Object *obj)
{
+ if (!obj) {
+ return;
+ }
g_assert(obj->ref > 0);
/* parent always holds a reference to its children */
@@ -1133,13 +1139,9 @@ static void object_set_link_property(Object *obj,
Visitor *v, void *opaque,
return;
}
- if (new_target) {
- object_ref(new_target);
- }
+ object_ref(new_target);
*child = new_target;
- if (old_target != NULL) {
- object_unref(old_target);
- }
+ object_unref(old_target);
}
static Object *object_resolve_link_property(Object *parent, void *opaque,
--
2.0.0
- [Qemu-devel] [PATCH memory v4 00/10] Memory Region QOMification, Peter Crosthwaite, 2014/06/06
- [Qemu-devel] [PATCH memory v4 01/10] memory: Simplify mr_add_subregion() if-else, Peter Crosthwaite, 2014/06/06
- [Qemu-devel] [PATCH memory v4 02/10] qom: add a generic mechanism to resolve paths, Peter Crosthwaite, 2014/06/06
- [Qemu-devel] [PATCH memory v4 03/10] qom: object: Ignore refs/unrefs of NULL,
Peter Crosthwaite <=
- [Qemu-devel] [PATCH memory v4 04/10] qom: Publish object_resolve_link, Peter Crosthwaite, 2014/06/06
- [Qemu-devel] [PATCH memory v4 05/10] memory: Coreify subregion add functionality, Peter Crosthwaite, 2014/06/06
- [Qemu-devel] [PATCH memory v4 06/10] memory: MemoryRegion: factor out memory region re-adder, Peter Crosthwaite, 2014/06/06
- [Qemu-devel] [PATCH memory v4 07/10] memory: MemoryRegion: QOMify, Peter Crosthwaite, 2014/06/06
- [Qemu-devel] [PATCH memory v4 08/10] memory: MemoryRegion: Add container and addr props, Peter Crosthwaite, 2014/06/06
- [Qemu-devel] [PATCH memory v4 09/10] memory: MemoryRegion: Add may-overlap and priority props, Peter Crosthwaite, 2014/06/06
- [Qemu-devel] [PATCH memory v4 10/10] memory: MemoryRegion: Add size property, Peter Crosthwaite, 2014/06/06
- Re: [Qemu-devel] [PATCH memory v4 00/10] Memory Region QOMification, Paolo Bonzini, 2014/06/06