Re: [Qemu-devel] [PATCH v4 33/33] pc: ACPI BIOS: make GPE.3 handle memory hotplug event on PIIX and Q35 machines

[Michael S. Tsirkin]

On Fri, Jun 06, 2014 at 05:23:06PM +0200, Igor Mammedov wrote:
> On Fri, 06 Jun 2014 08:44:23 -0400
> Don Slutz <address@hidden> wrote:
> 
> > This also generates warnings during "make check":
> > 
> > 
> > GTESTER check-qtest-i386
> > blkdebug: Suspended request 'A'
> > blkdebug: Resuming request 'A'
> > main-loop: WARNING: I/O thread spun for 1000 iterations
> > acpi-test: Warning! DSDT mismatch. Actual [asl:/tmp/asl-6P9HHX.dsl, 
> > aml:/tmp/aml-ACAIHX], Expected [asl:/tmp/asl-2Y4GHX.dsl, 
> > aml:tests/acpi-test-data/pc/DSDT].
> > main-loop: WARNING: I/O thread spun for 1000 iterations
> > acpi-test: Warning! DSDT mismatch. Actual [asl:/tmp/asl-T24HHX.dsl, 
> > aml:/tmp/aml-SO5HHX], Expected [asl:/tmp/asl-BYAIHX.dsl, 
> > aml:tests/acpi-test-data/q35/DSDT].
> That should be so for now, series intended to go through pci tree,
> and commiter /mst/ is going to update tests and binary *.hex blobs for 
> iasl-less setups.


Yes, these warnings are fine.
It's exactly the reason these are warnings and not errors,
they tend to pop up in the intermediate stage after patch applied
and before expected binary is updated.

> > 
> >     -Don Slutz
> > 
> > On 06/02/14 09:25, Igor Mammedov wrote:
> > > also make handler edge based to avoid losing events, the same as
> > > it has been done for PCI and CPU hotplug handlers.
> > >
> > > Signed-off-by: Igor Mammedov <address@hidden>
> > > Acked-by: Peter Crosthwaite <address@hidden>
> > > ---
> > > v2:
> > >   * use memory hotplug crtl located under PCI0
> > > ---
> > >   hw/i386/acpi-dsdt.dsl     |    5 ++++-
> > >   hw/i386/q35-acpi-dsdt.dsl |    5 ++++-
> > >   2 files changed, 8 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/hw/i386/acpi-dsdt.dsl b/hw/i386/acpi-dsdt.dsl
> > > index 8ae933b..3cc0ea0 100644
> > > --- a/hw/i386/acpi-dsdt.dsl
> > > +++ b/hw/i386/acpi-dsdt.dsl
> > > @@ -314,6 +314,7 @@ DefinitionBlock (
> > >   /****************************************************************
> > >    * General purpose events
> > >    ****************************************************************/
> > > +    External(\_SB.PCI0.MEMORY_HOPTLUG_DEVICE.MEMORY_SLOT_SCAN_METHOD, 
> > > MethodObj)
> > >   
> > >       Scope(\_GPE) {
> > >           Name(_HID, "ACPI0006")
> > > @@ -330,7 +331,9 @@ DefinitionBlock (
> > >               // CPU hotplug event
> > >               \_SB.PRSC()
> > >           }
> > > -        Method(_L03) {
> > > +        Method(_E03) {
> > > +            // Memory hotplug event
> > > +            \_SB.PCI0.MEMORY_HOPTLUG_DEVICE.MEMORY_SLOT_SCAN_METHOD()
> > >           }
> > >           Method(_L04) {
> > >           }
> > > diff --git a/hw/i386/q35-acpi-dsdt.dsl b/hw/i386/q35-acpi-dsdt.dsl
> > > index fddc3b2..8c3eae7 100644
> > > --- a/hw/i386/q35-acpi-dsdt.dsl
> > > +++ b/hw/i386/q35-acpi-dsdt.dsl
> > > @@ -410,6 +410,7 @@ DefinitionBlock (
> > >   /****************************************************************
> > >    * General purpose events
> > >    ****************************************************************/
> > > +    External(\_SB.PCI0.MEMORY_HOPTLUG_DEVICE.MEMORY_SLOT_SCAN_METHOD, 
> > > MethodObj)
> > >   
> > >       Scope(\_GPE) {
> > >           Name(_HID, "ACPI0006")
> > > @@ -422,7 +423,9 @@ DefinitionBlock (
> > >               // CPU hotplug event
> > >               \_SB.PRSC()
> > >           }
> > > -        Method(_L03) {
> > > +        Method(_E03) {
> > > +            // Memory hotplug event
> > > +            \_SB.PCI0.MEMORY_HOPTLUG_DEVICE.MEMORY_SLOT_SCAN_METHOD()
> > >           }
> > >           Method(_L04) {
> > >           }
> >