Re: [Qemu-devel] [PATCH 2/3] console: rework text terminal cursor logic

[Ian Campbell]

On Thu, 2014-05-22 at 13:00 +0200, Gerd Hoffmann wrote:
> Have a global timer.  Update all visible terminal windows syncronously.
> Right now this can be the active_console only, but that will change
> soon.  The global timer will disable itself if not needed, so we only
> have to care start it if needed.  Which might be at console switch time
> or when a new displaychangelistener is registered.

Running current master (d7d3d6092cb7) I'm seeing a segmentation fault
while running:
        ./aarch64-softmmu/qemu-system-aarch64 -M virt -cpu cortex-a57
        -sdl
which goes away if I revert this patch. qemu is configured with
        ./configure --target-list=aarch64-softmmu  --enable-sdl

The backtrace shows that the timer is NULL.

Program received signal SIGSEGV, Segmentation fault.
0x0000555555778204 in timer_mod (ts=0x0, expire_time=662170703) at 
qemu-timer.c:442
442         timer_mod_ns(ts, expire_time * ts->scale);
(gdb) bt
#0  0x0000555555778204 in timer_mod (ts=0x0, expire_time=662170703) at 
qemu-timer.c:442
#1  0x0000555555796130 in text_console_update_cursor_timer () at 
ui/console.c:1703
#2  text_console_update_cursor (address@hidden) at ui/console.c:1725
#3  0x0000555555798feb in register_displaychangelistener (dcl=<optimized out>) 
at ui/console.c:1316
#4  0x00005555557a250f in sdl_display_init (address@hidden, 
full_screen=-446133248, no_frame=<optimized out>)
    at ui/sdl.c:946
#5  0x00005555555f50a7 in main (argc=<optimized out>, argv=<optimized out>, 
envp=<optimized out>) at vl.c:4475

Cheers,
Ian.