[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 3/6] json-parser: Fix two coverity defects
From: |
Gonglei (Arei) |
Subject: |
Re: [Qemu-devel] [PATCH v2 3/6] json-parser: Fix two coverity defects |
Date: |
Tue, 10 Jun 2014 06:51:59 +0000 |
> -----Original Message-----
> From: Luiz Capitulino [mailto:address@hidden
> Sent: Tuesday, June 10, 2014 4:16 AM
> To: Gonglei (Arei)
> Cc: address@hidden; address@hidden; address@hidden;
> address@hidden; address@hidden; address@hidden;
> address@hidden; address@hidden; address@hidden; Huangweidong
> (C); address@hidden; address@hidden; address@hidden;
> address@hidden; address@hidden; address@hidden;
> Luonengjun; chenliang (T)
> Subject: Re: [PATCH v2 3/6] json-parser: Fix two coverity defects
>
> On Wed, 28 May 2014 21:21:37 +0800
> <address@hidden> wrote:
>
> > From: Gonglei <address@hidden>
> >
> > Pointer "token" returned by "parser_context_pop_token(ctxt)" is never used.
>
> That's not true, "token" is used by token_is_operator(). The patch seems
> correct to me, but you have to fix the changelog.
>
OK.
> Also, who's going to take care of this series? I'm willing to cherry-pick
> this patch...
>
Thanks. As this patch series, [PATCH 1/6] vnc-enc-tight... had been applied by
Gerd,
the others haven't.
I will send v3 for other patches, hope to be applied, thanks!
Best regards,
-Gonglei