Re: [Qemu-devel] [PATCH] rules.mak: remove $(sort) from extract-libs

[Peter Maydell]

On 16 June 2014 15:43, Paolo Bonzini <address@hidden> wrote:
> Duplicate removal was added to extract-libs in order to avoid including
> the same library multiple times into the linking command line; this could
> potentially happen when using "foo.mo-libs" (which adds the library to
> all components, causing it to appear N times if the module is composed
> of N objects).  However, sorting and removing duplicates causes problems
> with static linking, and also with space-separated linker options as
> found in some Mac OS X packaging systems.  Furthermore, the "optimization"
> is really a non-problem since we do not expect .mo modules to be composed
> of many files.
>
> Reported-by: Sean Bruno <address@hidden>
> Tested-by: Sean Bruno <address@hidden>
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
>         Peter, can you please apply this directly as it fixes the
>         build and there are no other pending patches?
> ---

Applied, thanks.

-- PMM