qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 5/5] mc146818rtc: add "rtc" link to "/machine"


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH 5/5] mc146818rtc: add "rtc" link to "/machine"
Date: Tue, 17 Jun 2014 17:01:50 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0

Il 17/06/2014 16:25, Peter Crosthwaite ha scritto:
> &error_warn? :)  But then, /machine/rtc.tm is the only supported interface,
I have thought about &error_warn in the past, but thought the better
of it. Warnings need user digestable message and I can't think of a
sane implementation where you populate a message for error framework
to raise while maintaining the needed errp == NULL || *errp == NULL
semantic at the same time.

> and it should be the same for all RTC devices so perhaps a NULL error
> pointer is enough.
>
NULL Works for me. But other than source verbosity is there any reason
to not catch the error?:

See above: it doesn't matter _which_ RTC gets the magic alias. For a proper implementation, they should all be the same.

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]