[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/3] fixup! qapi/string-output-visitor: fix bugs
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 2/3] fixup! qapi/string-output-visitor: fix bugs |
Date: |
Fri, 20 Jun 2014 09:34:37 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 |
On 06/19/2014 11:55 PM, Hu Tao wrote:
> "0x1-0x10" looks better than "0x1-10"
>
> Signed-off-by: Hu Tao <address@hidden>
> ---
> qapi/string-output-visitor.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Eric Blake <address@hidden>
>
> diff --git a/qapi/string-output-visitor.c b/qapi/string-output-visitor.c
> index e9aca3b..1ab8574 100644
> --- a/qapi/string-output-visitor.c
> +++ b/qapi/string-output-visitor.c
> @@ -98,7 +98,7 @@ static void format_string(StringOutputVisitor *sov, Range
> *r, bool next,
> {
> if (r->end - r->begin > 1) {
> if (human) {
> - g_string_append_printf(sov->string, "0x%" PRIx64 "-%" PRIx64,
> + g_string_append_printf(sov->string, "0x%" PRIx64 "-0x%" PRIx64,
> r->begin, r->end - 1);
>
> } else {
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH 0/3] another round of pci fixes, Hu Tao, 2014/06/20
- [Qemu-devel] [PATCH 1/3] fixup! libqemustub: add more stubs for qemu-char, Hu Tao, 2014/06/20
- [Qemu-devel] [PATCH 2/3] fixup! qapi/string-output-visitor: fix bugs, Hu Tao, 2014/06/20
- Re: [Qemu-devel] [PATCH 2/3] fixup! qapi/string-output-visitor: fix bugs,
Eric Blake <=
- [Qemu-devel] [PATCH 3/3] tests: add human format test for string output visitor, Hu Tao, 2014/06/20
- Re: [Qemu-devel] [PATCH 0/3] another round of pci fixes, Michael S. Tsirkin, 2014/06/22
- Re: [Qemu-devel] [PATCH 0/3] another round of pci fixes, Michael S. Tsirkin, 2014/06/29