qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PULL 20/23] pcie: coding style tweak


From: Michael S. Tsirkin
Subject: [Qemu-devel] [PULL 20/23] pcie: coding style tweak
Date: Mon, 23 Jun 2014 18:54:14 +0300

- whitespace fix
- unnecessary != 0 in a condition

Cc: Marcel Apfelbaum <address@hidden>
Signed-off-by: Michael S. Tsirkin <address@hidden>
---
 hw/pci/pcie.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/hw/pci/pcie.c b/hw/pci/pcie.c
index da32589..a123c01 100644
--- a/hw/pci/pcie.c
+++ b/hw/pci/pcie.c
@@ -353,11 +353,9 @@ void pcie_cap_slot_reset(PCIDevice *dev)
                                PCI_EXP_SLTCTL_AIC_OFF);
 
     if (dev->cap_present & QEMU_PCIE_SLTCAP_PCP) {
-        bool populated;
-        uint16_t pic;
-
         /* Downstream ports enforce device number 0. */
-        populated = (pci_bridge_get_sec_bus(PCI_BRIDGE(dev))->devices[0] != 
NULL);
+        bool populated = pci_bridge_get_sec_bus(PCI_BRIDGE(dev))->devices[0];
+        uint16_t pic;
 
         if (populated) {
             pci_word_test_and_clear_mask(exp_cap + PCI_EXP_SLTCTL,
@@ -369,7 +367,7 @@ void pcie_cap_slot_reset(PCIDevice *dev)
 
         pic = populated ? PCI_EXP_SLTCTL_PIC_ON : PCI_EXP_SLTCTL_PIC_OFF;
         pci_word_test_and_set_mask(exp_cap + PCI_EXP_SLTCTL, pic);
-     }
+    }
 
     pci_word_test_and_clear_mask(exp_cap + PCI_EXP_SLTSTA,
                                  PCI_EXP_SLTSTA_EIS |/* on reset,
-- 
MST




reply via email to

[Prev in Thread] Current Thread [Next in Thread]