[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] AArch64 linux-user: SA_ONSTACK usage in get_sigframe
|
From: |
Riku Voipio |
|
Subject: |
Re: [Qemu-devel] AArch64 linux-user: SA_ONSTACK usage in get_sigframe |
|
Date: |
Tue, 24 Jun 2014 15:15:29 +0300 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Mon, Jun 23, 2014 at 06:15:03PM +0200, Laurent Desnogues wrote:
> Hello,
>
> in linux-user/signal.c the code for AArch64 get_sigframe reads like this:
>
> if ((ka->sa_flags & SA_ONSTACK) && !sas_ss_flags(sp)) {
>
> Shouldn't that be TARGET_SA_ONSTACK?
> The same question applies to Microblaze and OpenRISC.
Correct. Most people wont just notice since SA_ONSTACK appears to be
0x08000000 for everything but alpha and parisc where it is 1.
Riku