[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 7/9] block: Remove second bdrv_open() recursi
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v2 7/9] block: Remove second bdrv_open() recursion |
Date: |
Wed, 25 Jun 2014 09:52:25 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 |
On 06/25/2014 08:35 AM, Kevin Wolf wrote:
> This recursion was introduced in commit 505d7583 in order to allow
> nesting image formats. It only ever takes effect when the user
> explicitly specifies a driver name and that driver isn't suitable for
> the protocol level.
>
> We can check this earlier in bdrv_open() and if the explicitly
> requested driver is a format driver, clear BDRV_O_PROTOCOL so that
> another bs->file layer is opened.
>
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
> block.c | 50 +++++++++++++++++++++++++-------------------------
> 1 file changed, 25 insertions(+), 25 deletions(-)
>
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v2 2/9] block: Move bdrv_fill_options() call to bdrv_open(), (continued)
- [Qemu-devel] [PATCH v2 2/9] block: Move bdrv_fill_options() call to bdrv_open(), Kevin Wolf, 2014/06/25
- [Qemu-devel] [PATCH v2 1/9] block: Create bdrv_fill_options(), Kevin Wolf, 2014/06/25
- [Qemu-devel] [PATCH v2 5/9] block: Use common driver selection code for bdrv_open_file(), Kevin Wolf, 2014/06/25
- [Qemu-devel] [PATCH v2 3/9] block: Move json: parsing to bdrv_fill_options(), Kevin Wolf, 2014/06/25
- [Qemu-devel] [PATCH v2 4/9] block: Always pass driver name through options QDict, Kevin Wolf, 2014/06/25
- [Qemu-devel] [PATCH v2 6/9] block: Inline bdrv_file_open(), Kevin Wolf, 2014/06/25
- [Qemu-devel] [PATCH v2 7/9] block: Remove second bdrv_open() recursion, Kevin Wolf, 2014/06/25
- Re: [Qemu-devel] [PATCH v2 7/9] block: Remove second bdrv_open() recursion,
Eric Blake <=
- [Qemu-devel] [PATCH v2 8/9] block: Catch backing files assigned to non-COW drivers, Kevin Wolf, 2014/06/25
- [Qemu-devel] [PATCH v2 9/9] block: Remove a special case for protocols, Kevin Wolf, 2014/06/25
- Re: [Qemu-devel] [PATCH v2 0/9] bdrv_open() cleanups, part 1, Kevin Wolf, 2014/06/26
- Re: [Qemu-devel] [PATCH v2 0/9] bdrv_open() cleanups, part 1, Max Reitz, 2014/06/26