Re: [Qemu-devel] [PATCH 1/3 v3] ppc: spapr-rtas - implement os-term rtas call

[Nikunj A Dadhania]

Nikunj A Dadhania <address@hidden> writes:

> PAPR compliant guest calls this in absence of kdump. This finally
> reaches the guest and can be handled according to the policies set by
> higher level tools(like taking dump) for further analysis by tools like
> crash.
>
> Linux kernel calls this only when the extended version of os,term is
> implemented to make sure that a return to the linux kernel is gauranteed.
>
> CC: Benjamin Herrenschmidt <address@hidden>
> CC: Anton Blanchard <address@hidden>
> CC: Alexander Graf <address@hidden>
> Signed-off-by: Nikunj A Dadhania <address@hidden>
>
> ---
>
> v2: rebase to ppcnext
> v3: Do not stop the VM, and update comments
> ---
>  hw/ppc/spapr_rtas.c | 41 +++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 41 insertions(+)
>
> diff --git a/hw/ppc/spapr_rtas.c b/hw/ppc/spapr_rtas.c
> index 9ba1ba6..2da33c8 100644
> --- a/hw/ppc/spapr_rtas.c
> +++ b/hw/ppc/spapr_rtas.c
> @@ -29,6 +29,8 @@
>  #include "sysemu/char.h"
>  #include "hw/qdev.h"
>  #include "sysemu/device_tree.h"
> +#include "qapi/qmp/qjson.h"
> +#include "monitor/monitor.h"
>
>  #include "hw/ppc/spapr.h"
>  #include "hw/ppc/spapr_vio.h"
> @@ -277,6 +279,41 @@ static void rtas_ibm_set_system_parameter(PowerPCCPU 
> *cpu,
>      rtas_st(rets, 0, ret);
>  }
>
> +static void rtas_ibm_os_term(PowerPCCPU *cpu,
> +                            sPAPREnvironment *spapr,
> +                            uint32_t token, uint32_t nargs,
> +                            target_ulong args,
> +                            uint32_t nret, target_ulong rets)
> +{
> +    target_ulong ret = 0;
> +    QObject *data;
> +
> +    data = qobject_from_jsonf("{ 'action': %s }", "pause");
> +    monitor_protocol_event(QEVENT_GUEST_PANICKED, data);
> +    qobject_decref(data);

Even the above has got changed, and newer api:  qapi_event_send_guest_panicked

Regards
Nikunj