[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC 00/14] VGA cleanups and endian control
From: |
Gerd Hoffmann |
Subject: |
Re: [Qemu-devel] [RFC 00/14] VGA cleanups and endian control |
Date: |
Mon, 30 Jun 2014 15:03:38 +0200 |
On Mo, 2014-06-30 at 22:36 +1000, Benjamin Herrenschmidt wrote:
> On Mon, 2014-06-30 at 13:50 +0200, Gerd Hoffmann wrote:
> > On Di, 2014-06-24 at 09:10 +1000, Benjamin Herrenschmidt wrote:
> > > This series cleans up VGA and a bit of cirrus to remove all
> > > the now unused conversions to non-32bpp surfaces. Then the last
> > > two patches add a proposed variant of the endian control register
> > > and the (still somewhat controversial) trick to auto-switch VGA
> > > endian on powerpc SPAPR platforms.
> > >
> > > They apply on top of Gerd pixel format series
> >
> > Looks good overall. I'll go test this when I find time, after flushing
> > my email backlog ...
>
> Thanks. The main issues I know of at this point are the HW cursor vs.
> cirrus and the lack of response from the Bochs guys...
>
> I'll respin based on your other comments some time this or next week,
> let me know if there's any other low hanging fruit in that area that I
> can take care of while I'm at it.
One thing I've planed to do is rewrite text mode rendering. There are
some helpers for that in ui/qemu-pixman.c. They are used by the qemu
text console today (i.e. "-chardev vc" + Ctrl-Alt-$nr console switching,
see ui/console.c). In theory these helpers should work as-is for vga
text mode rendering too, allowing to zap a whole bunch of glyph drawing
code from vga.c.
Not sure how low hanging that actually is though ...
cheers,
Gerd
- [Qemu-devel] [RFC 05/14] vga: Remove unused vga_draw_line24() and vga_draw_line32(), (continued)
- [Qemu-devel] [RFC 05/14] vga: Remove unused vga_draw_line24() and vga_draw_line32(), Benjamin Herrenschmidt, 2014/06/23
- [Qemu-devel] [RFC 11/14] vga: Make fb endian a common state variable, Benjamin Herrenschmidt, 2014/06/23
- [Qemu-devel] [RFC 14/14] ppc/spapr/vga: Switch VGA endian on H_SET_MODE, Benjamin Herrenschmidt, 2014/06/23
- [Qemu-devel] [RFC 02/14] ui: Remove unused QEMU_BIG_ENDIAN_FLAG, Benjamin Herrenschmidt, 2014/06/23
- Re: [Qemu-devel] [RFC 00/14] VGA cleanups and endian control, Gerd Hoffmann, 2014/06/30