Re: [Qemu-devel] [PATCH v2 2.1 3/3] docs/qmp: Fix documentation of BLOCK_JOB_READY to match code

[Markus Armbruster]

Eric Blake <address@hidden> writes:

> On 06/27/2014 11:24 AM, Markus Armbruster wrote:
>> Signed-off-by: Markus Armbruster <address@hidden>
>> ---
>>  docs/qmp/qmp-events.txt | 12 ++++++++++--
>>  1 file changed, 10 insertions(+), 2 deletions(-)
>> 
>> diff --git a/docs/qmp/qmp-events.txt b/docs/qmp/qmp-events.txt
>> index 22fea58..44be891 100644
>> --- a/docs/qmp/qmp-events.txt
>> +++ b/docs/qmp/qmp-events.txt
>> @@ -157,12 +157,20 @@ Emitted when a block job is ready to complete.
>>  
>>  Data:
>>  
>> -- "device": device name (json-string)
>> +- "type":     Job type (json-string; "stream" for image streaming
>> +                                     "commit" for block commit)
>> +- "device":   Device name (json-string)
>> +- "len":      Maximum progress value (json-int)
>> +- "offset":   Current progress value (json-int)
>> +              On success this is equal to len.
>> +              On failure this is less than len.
>> +- "speed":    Rate limit, bytes per second (json-int)
>>  
>
> Design question - if BLOCK_JOB_READY reports failure (that is, offset <
> len), are we still guaranteed to get a BLOCK_JOB_COMPLETED that also
> reports failure, or does 'query-blockjobs' completely forget about the
> job?

Good one.  It's underspecified, as far as I can tell.  First step to fix
that is to find out what the code does.

>      If the job is completely lost, what recourse does management have
> to learn about the failure (that is, if libvirtd restarts, how will it
> learn whether a previously running job was aborted due to an error, if
> it missed the event)?

Let's worry about that when we know what the code does.