[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/2] coroutine: make pool size dynamic
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 1/2] coroutine: make pool size dynamic |
Date: |
Thu, 03 Jul 2014 07:59:10 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 |
On 07/03/2014 07:52 AM, Stefan Hajnoczi wrote:
> Allow coroutine users to adjust the pool size. For example, if the
> guest has multiple emulated disk drives we should keep around more
> coroutines.
>
> Signed-off-by: Stefan Hajnoczi <address@hidden>
> ---
> include/block/coroutine.h | 11 +++++++++++
> qemu-coroutine.c | 25 +++++++++++++++++++------
> 2 files changed, 30 insertions(+), 6 deletions(-)
>
> +
> +void qemu_coroutine_adjust_pool_size(int n)
> +{
> + qemu_mutex_lock(&pool_lock);
> +
> + pool_max_size += n;
Where do you check that this doesn't fall below a bare-minimum
acceptable level? Is it worth assert(pool_max_size >= 64)?
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature