[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH 0/5] modify boot order when vm is running
From: |
Laszlo Ersek |
Subject: |
Re: [Qemu-devel] [RFC PATCH 0/5] modify boot order when vm is running |
Date: |
Mon, 07 Jul 2014 16:40:02 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 |
On 07/07/14 13:12, Gonglei (Arei) wrote:
>
>
>
>
>
>
>
>> -----Original Message-----
>> From: Laszlo Ersek [mailto:address@hidden
>> Sent: Monday, July 07, 2014 6:04 PM
>> To: Michael S. Tsirkin; Gonglei (Arei)
>> Cc: address@hidden; address@hidden; address@hidden;
>> address@hidden; address@hidden; address@hidden;
>> address@hidden; address@hidden; address@hidden;
>> address@hidden; address@hidden; address@hidden;
>> address@hidden; address@hidden; address@hidden;
>> address@hidden; address@hidden; address@hidden;
>> address@hidden; address@hidden; Huangweidong (C); Luonengjun;
>> Huangpeng (Peter); chenliang (T)
>> Subject: Re: [RFC PATCH 0/5] modify boot order when vm is running
>>
>> On 07/07/14 11:29, Michael S. Tsirkin wrote:
>>> On Mon, Jul 07, 2014 at 05:10:56PM +0800, address@hidden
>> wrote:
>>>> From: Chenliang <address@hidden>
>>>>
>>>> Sometime, we want to modify boot order of vm without shutdown it.
>>>> This sets of patches add one qmp to achieve it. And fix some little
>>>> bug when device is hotpluged.
>>>>
>>>> Chenliang (5):
>>>> bootindex: add *_boot_device_path function
>>>> bootindex: reset bootindex when vm reset
>>>> bootindex: delete boot index when device is removed
>>>> bootindex: add qmp to set boot index when vm is running
>>>> bootindex: fix memory leak when ppc sets boot index
>>>
>>> Unfortunately at least for PC, boot order is exposed
>>> in fw cfg which can not change while guest is running.
>>> I suspect we need to change how we report boot order to guests.
>>> While we are at it, maybe we can fix the silly bootindex
>>> convention: I think people really want to specify boot *order*,
>>> not boot index.
>>
>> Please preserve the "bootorder" fw_cfg file, and its format.
>>
>> I don't have any request in relation to the new (== dynamic) feature ATM.
>>
> Sorry, I can't understand your meaning exactly.
> Would you explain it? Thanks!
I meant that whatever features you introduce, please make sure that a
guest looking for the "bootorder" fw_cfg file will find it, and that the
contents and the format of that fw_cfg file stays the same, for the same
qemu command line options.
I'm not implying that your current series changes the "bootorder" fw_cfg
file (I have not looked at your patches); this is just a general request
I make out of caution.
Thanks
Laszlo
- Re: [Qemu-devel] [RFC PATCH 1/5] bootindex: add *_boot_device_path function, (continued)
[Qemu-devel] [RFC PATCH 2/5] bootindex: reset bootindex when vm reset, arei.gonglei, 2014/07/07
[Qemu-devel] [RFC PATCH 3/5] bootindex: delete boot index when device is removed, arei.gonglei, 2014/07/07
[Qemu-devel] [RFC PATCH 5/5] bootindex: fix memory leak when set boot index, arei.gonglei, 2014/07/07
Re: [Qemu-devel] [RFC PATCH 0/5] modify boot order when vm is running, Michael S. Tsirkin, 2014/07/07
Re: [Qemu-devel] [RFC PATCH 0/5] modify boot order when vm is running, Gonglei (Arei), 2014/07/07