[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 15/28] ide: stop PIO transfer on errors
From: |
John Snow |
Subject: |
[Qemu-devel] [PATCH 15/28] ide: stop PIO transfer on errors |
Date: |
Mon, 7 Jul 2014 14:17:56 -0400 |
From: Paolo Bonzini <address@hidden>
This will provide a hook for sending the result of the command via the
FIS receive area.
Signed-off-by: Paolo Bonzini <address@hidden>
Signed-off-by: John Snow <address@hidden>
---
hw/ide/core.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/hw/ide/core.c b/hw/ide/core.c
index bd3bd34..d900ba0 100644
--- a/hw/ide/core.c
+++ b/hw/ide/core.c
@@ -422,6 +422,9 @@ static inline void ide_abort_command(IDEState *s)
{
s->status = READY_STAT | ERR_STAT;
s->error = ABRT_ERR;
+ if (s->end_transfer_func != ide_transfer_stop) {
+ ide_transfer_stop(s);
+ }
}
/* prepare data transfer and tell what to do after */
@@ -588,9 +591,7 @@ void ide_set_inactive(IDEState *s, bool more)
void ide_dma_error(IDEState *s)
{
- ide_transfer_stop(s);
- s->error = ABRT_ERR;
- s->status = READY_STAT | ERR_STAT;
+ ide_abort_command(s);
ide_set_inactive(s, false);
ide_set_irq(s->bus);
}
--
1.9.3
- [Qemu-devel] [PATCH 14/28] ahci: remove duplicate PORT_IRQ_* constants, (continued)
- [Qemu-devel] [PATCH 14/28] ahci: remove duplicate PORT_IRQ_* constants, John Snow, 2014/07/07
- [Qemu-devel] [PATCH 09/28] ide: wrap start_dma callback, John Snow, 2014/07/07
- [Qemu-devel] [PATCH 13/28] ide: move retry constants out of BM_STATUS_* namespace, John Snow, 2014/07/07
- [Qemu-devel] [PATCH 16/28] ide: make all commands go through cmd_done, John Snow, 2014/07/07
- [Qemu-devel] [PATCH 10/28] ide: remove wrong setting of BM_STATUS_INT, John Snow, 2014/07/07
- [Qemu-devel] [PATCH 15/28] ide: stop PIO transfer on errors,
John Snow <=
- [Qemu-devel] [PATCH 17/28] ahci: construct PIO Setup FIS for PIO commands, John Snow, 2014/07/07
- [Qemu-devel] [PATCH 18/28] q35: Enable the ioapic device to be seen by qtest., John Snow, 2014/07/07
- [Qemu-devel] [PATCH 21/28] libqtest: Correct small memory leak., John Snow, 2014/07/07
- [Qemu-devel] [PATCH 27/28] ahci: Add test_hba_enable to ahci-test., John Snow, 2014/07/07