Re: [Qemu-devel] [PATCH v2 0/4] virtio-blk: fix issues with unified virtio-blk request handling

[Kevin Wolf]

Am 08.07.2014 um 16:43 hat Stefan Hajnoczi geschrieben:
> On Tue, Jul 1, 2014 at 5:25 PM, Stefan Hajnoczi <address@hidden> wrote:
> > This series fixes issues recently introduced when unifying virtio-blk
> > dataplane's request handling with non-dataplane virtio-blk.
> >
> > The problems include broken memory allocation for dataplane requests and a
> > performance regression for non-dataplane.  See the patches for details.
> >
> > Stefan Hajnoczi (4):
> >   virtio-blk: avoid dataplane VirtIOBlockReq early free
> >   dataplane: do not free VirtQueueElement in vring_push()
> >   virtio-blk: avoid g_slice_new0() for VirtIOBlockReq and
> >     VirtQueueElement
> >   virtio-blk: embed VirtQueueElement in VirtIOBlockReq
> >
> >  hw/block/dataplane/virtio-blk.c     | 30 +++++++++++-----------
> >  hw/block/virtio-blk.c               | 50 
> > ++++++++++++++++++-------------------
> >  hw/virtio/dataplane/vring.c         | 22 ++++++----------
> >  include/hw/virtio/dataplane/vring.h |  3 +--
> >  include/hw/virtio/virtio-blk.h      |  6 ++++-
> >  5 files changed, 53 insertions(+), 58 deletions(-)
> 
> Hi Kevin,
> Please include this series in your block pull request.  I missed it
> last week and it's needed to fix dataplane in QEMU 2.1.

Patch 4 doesn't seem to apply any more. Can you rebase (and include the
Tested-by tags of Christian)?

Kevin