[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [RFC 04/25] accel: Simplify configure_accelerator() using A
From: |
Eduardo Habkost |
Subject: |
[Qemu-devel] [RFC 04/25] accel: Simplify configure_accelerator() using AccelType *acc variable |
Date: |
Wed, 9 Jul 2014 19:04:01 -0300 |
Signed-off-by: Eduardo Habkost <address@hidden>
---
hw/core/accel.c | 18 ++++++++++--------
1 file changed, 10 insertions(+), 8 deletions(-)
diff --git a/hw/core/accel.c b/hw/core/accel.c
index c23c04b..00a71c0 100644
--- a/hw/core/accel.c
+++ b/hw/core/accel.c
@@ -62,6 +62,7 @@ int configure_accelerator(MachineClass *mc)
int i, ret;
bool accel_initialised = false;
bool init_failed = false;
+ AccelType *acc = NULL;
p = qemu_opt_get(qemu_get_machine_opts(), "accel");
if (p == NULL) {
@@ -75,20 +76,21 @@ int configure_accelerator(MachineClass *mc)
}
p = get_opt_name(buf, sizeof(buf), p, ':');
for (i = 0; i < ARRAY_SIZE(accel_list); i++) {
- if (strcmp(accel_list[i].opt_name, buf) == 0) {
- if (!accel_list[i].available()) {
+ acc = &accel_list[i];
+ if (strcmp(acc->opt_name, buf) == 0) {
+ if (!acc->available()) {
printf("%s not supported for this target\n",
- accel_list[i].name);
+ acc->name);
break;
}
- *(accel_list[i].allowed) = true;
- ret = accel_list[i].init(mc);
+ *(acc->allowed) = true;
+ ret = acc->init(mc);
if (ret < 0) {
init_failed = true;
fprintf(stderr, "failed to initialize %s: %s\n",
- accel_list[i].name,
+ acc->name,
strerror(-ret));
- *(accel_list[i].allowed) = false;
+ *(acc->allowed) = false;
} else {
accel_initialised = true;
}
@@ -108,7 +110,7 @@ int configure_accelerator(MachineClass *mc)
}
if (init_failed) {
- fprintf(stderr, "Back to %s accelerator.\n", accel_list[i].name);
+ fprintf(stderr, "Back to %s accelerator.\n", acc->name);
}
return !accel_initialised;
--
1.9.3
- [Qemu-devel] [RFC 00/25] QOMify accelerator code, Eduardo Habkost, 2014/07/09
- [Qemu-devel] [RFC 01/25] vl.c: Small coding style fix, Eduardo Habkost, 2014/07/09
- [Qemu-devel] [RFC 03/25] accel: Create struct AccelType, Eduardo Habkost, 2014/07/09
- [Qemu-devel] [RFC 02/25] accel: Move accel code to accel.c, Eduardo Habkost, 2014/07/09
- [Qemu-devel] [RFC 05/25] accel: Move accel name lookup to separate function, Eduardo Habkost, 2014/07/09
- [Qemu-devel] [RFC 04/25] accel: Simplify configure_accelerator() using AccelType *acc variable,
Eduardo Habkost <=
- [Qemu-devel] [RFC 06/25] accel: Use QOM classes for accel types, Eduardo Habkost, 2014/07/09
- [Qemu-devel] [RFC 07/25] accel: Make AccelClass.available() optional, Eduardo Habkost, 2014/07/09
- [Qemu-devel] [RFC 08/25] accel: Move KVM accel registration to kvm-all.c, Eduardo Habkost, 2014/07/09
- [Qemu-devel] [RFC 09/25] accel: Move Xen registration code to xen-common.c, Eduardo Habkost, 2014/07/09
- [Qemu-devel] [RFC 10/25] accel: Move qtest accel registration to qtest.c, Eduardo Habkost, 2014/07/09
- [Qemu-devel] [RFC 11/25] accel: Remove tcg_available() function, Eduardo Habkost, 2014/07/09
- [Qemu-devel] [RFC 13/25] accel: Rename 'init' method to 'init_machine', Eduardo Habkost, 2014/07/09
- [Qemu-devel] [RFC 14/25] accel: Pass MachineState object to accel init functions, Eduardo Habkost, 2014/07/09
- [Qemu-devel] [RFC 12/25] accel: Move accel init/allowed code to separate function, Eduardo Habkost, 2014/07/09
- [Qemu-devel] [RFC 16/25] accel: Save AccelState on MachineState when initializing, Eduardo Habkost, 2014/07/09