Re: [Qemu-devel] [RFC v4 03/13] hw/vfio/pci: Remove unneeded include files

[Alex Williamson]

On Mon, 2014-07-07 at 13:27 +0100, Eric Auger wrote:
> Signed-off-by: Eric Auger <address@hidden>
> ---
>  hw/vfio/pci.c | 12 ------------
>  1 file changed, 12 deletions(-)
> 
> diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c
> index 5c7bfd5..a7df3de 100644
> --- a/hw/vfio/pci.c
> +++ b/hw/vfio/pci.c
> @@ -18,26 +18,14 @@
>   *  Copyright (C) 2008, IBM, Muli Ben-Yehuda (address@hidden)
>   */
>  
> -#include <dirent.h>
>  #include <linux/vfio.h>
>  #include <sys/ioctl.h>
>  #include <sys/mman.h>
> -#include <sys/stat.h>
> -#include <sys/types.h>
> -#include <unistd.h>
> -
> -#include "config.h"
>  #include "exec/address-spaces.h"
> -#include "exec/memory.h"
>  #include "hw/pci/msi.h"
>  #include "hw/pci/msix.h"
> -#include "hw/pci/pci.h"
> -#include "qemu-common.h"
>  #include "qemu/error-report.h"
> -#include "qemu/event_notifier.h"
> -#include "qemu/queue.h"
>  #include "qemu/range.h"
> -#include "sysemu/kvm.h"
>  #include "sysemu/sysemu.h"
>  #include "hw/vfio/vfio.h"

Was this just a remove and see if it still compiles exercise?  I'm not
sure I'm a fan of removing includes that are arbitrarily included via
another include chain.  Thanks,

Alex