[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 5/5] serial-pci: remove memory regions from BAR befor
From: |
Paolo Bonzini |
Subject: |
[Qemu-devel] [PULL 5/5] serial-pci: remove memory regions from BAR before destroying them |
Date: |
Mon, 14 Jul 2014 17:49:28 +0200 |
Otherwise, hot-unplug of pci-serial-2x trips the assertion
in memory_region_destroy:
(qemu) device_del gg
(qemu) qemu-system-x86_64: /work/armbru/tmp/qemu/memory.c:1021:
memory_region_destroy: Assertion `((&mr->subregions)->tqh_first == ((void
*)0))' failed.
Aborted (core dumped)
Reported-by: Markus Armbruster <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
---
hw/char/serial-pci.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/char/serial-pci.c b/hw/char/serial-pci.c
index f53bb9c..c133c33 100644
--- a/hw/char/serial-pci.c
+++ b/hw/char/serial-pci.c
@@ -148,6 +148,7 @@ static void multi_serial_pci_exit(PCIDevice *dev)
for (i = 0; i < pci->ports; i++) {
s = pci->state + i;
serial_exit_core(s);
+ memory_region_del_subregion(&pci->iobar, &s->io);
memory_region_destroy(&s->io);
g_free(pci->name[i]);
}
--
1.9.3
- [Qemu-devel] [PULL for-2.1 0/5] Serial + SCSI fixes for 2014-07-14, Paolo Bonzini, 2014/07/14
- [Qemu-devel] [PULL 2/5] qemu-char: fix deadlock with "-monitor pty", Paolo Bonzini, 2014/07/14
- [Qemu-devel] [PULL 3/5] serial: change retry logic to avoid concurrency, Paolo Bonzini, 2014/07/14
- [Qemu-devel] [PULL 1/5] scsi: Report error when lun number is in use, Paolo Bonzini, 2014/07/14
- [Qemu-devel] [PULL 4/5] virtio-scsi: fix with -M pc-i440fx-2.0, Paolo Bonzini, 2014/07/14
- [Qemu-devel] [PULL 5/5] serial-pci: remove memory regions from BAR before destroying them,
Paolo Bonzini <=
- Re: [Qemu-devel] [PULL for-2.1 0/5] Serial + SCSI fixes for 2014-07-14, Peter Maydell, 2014/07/15