Re: [Qemu-devel] [PATCH for-2.1 1/1] virtio-serial-bus: keep port 0 reserved for virtconsole even on unplug

[Paolo Bonzini]

Il 15/07/2014 11:23, Amit Shah ha scritto:
>      i = port_id / 32;

This can also be moved inside the if.

Paolo

> -    vser->ports_map[i] &= ~(1U << (port_id % 32));
> +    if (port_id) {
> +        /*
> +         * Don't mark port 0 removed -- we explicitly reserve it for
> +         * backward compat with older guests, and a device unplug of
> +         * virtconsole removes the reservation.
> +         */
> +        vser->ports_map[i] &= ~(1U << (port_id % 32));
> +    }