Re: [Qemu-devel] [PATCH v7 1/4] cpus: Define callback for QEMU "nmi" command

[Peter Maydell]

On 15 July 2014 15:50, Eric Blake <address@hidden> wrote:
> On 06/12/2014 09:36 PM, Alexey Kardashevskiy wrote:
>> This introduces an NMI (Non Maskable Interrupt) interface with
>> a single nmi_monitor_handler() method. A machine or a device can
>> implement it. This searches for an QOM object with this interface
>> and if it is implemented, calls it. The callback implements an action
>> required to cause debug crash dump on in-kernel debugger invocation.
>> The callback returns Error**.
>>
>> This adds a nmi_monitor_handle() helper which walks through
>> all objects to find the interface. The interface method is called
>> for all found instances.
>>
>> This adds support for it in qmp_inject_nmi(). Since no architecture
>> supports it at the moment, there is no change in behaviour.
>>
>> This changes inject-nmi command description for HMP and QMP.
>>
>> Signed-off-by: Alexey Kardashevskiy <address@hidden>
>> ---
>
>> +++ b/qapi-schema.json
>> @@ -1116,13 +1116,13 @@
>>  ##
>>  # @inject-nmi:
>>  #
>> -# Injects an Non-Maskable Interrupt into all guest's VCPUs.
>> +# Injects a Non-Maskable Interrupt into the default CPU (x86/s390) or all 
>> CPUs (ppc64).
>>  #
>>  # Returns:  If successful, nothing
>>  #
>>  # Since:  0.14.0
>>  #
>> -# Notes: Only x86 Virtual Machines support this command.
>> +# Note: prior to 2.1, this command was only supported for x86 and s390 VMs
>
> Are we still trying to get this into 2.1, or has it slipped to 2.2?

I think this is definitely too late at this point.

thanks
-- PMM