Re: [Qemu-devel] [PATCH v4 2/8] RunState: added two new flags for bitmap dump and migration process

[Sanidhya Kashyap]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

>> +# +# @migrate: migration process is being executed +# +#
>> @dump-bitmap: dump the writable working set of the guest
> 
> Please document these new flags as (since 2.2).
> 
> How does 'migrate' differ from 'inmigrate' and 'finish-migrate'?
> Why do you need to introduce 'dump-bitmap' again? How will this
> interact with older libvirt that doesn't know about the state?
> 

What I know is that 'inmigrate' is used on the destination side,
'finish-migrate' is the state for the last stage of migration on the
source when the VM is stopped. Whereas 'migrate' is the state when the
user gives a migrate command for which the runstate changes to
'migrate', if there is a satisfactory condition that allows migration.

I wanted to separate both visualize all the states properly. That's
why I introduced the 'dump-bitmap'. Another reason to support the
introduction is that there is no point in dumping the bitmap when the
VM is halted, so that's why 'dump-bitmap' is required. If the VM is
halted, then the dump-bitmap process will terminate. Well, that is my
thinking and it can either be redundant or useless.

I have no idea what will happen to the older libvirt. :-/

- -- 
- -----

Sanidhya Kashyap
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBAgAGBQJTyWESAAoJEFt9RLmoahlnesAIAJi2ZbPkZTvllPl0/n5oQmRm
hqegnl4ggsv8R9lpElcEtJKiwI0JpqwNzmNGp/nUmHqlq9cFgsC58AtdbRQGjDmx
52B7ySpa9Ptne5YTxHbNMj+o6RADdMCjENcYaWToFNftFQvfU8zgeQFnBn+wKKdL
hSqGdaZQ5ak1sQ8VJGjjBKWCiD/4dKZd5VVBk8FLPvVBxI/eVf0e5BKB+XnmpmNW
vElmJXckEOUGd/Uzj4sXRq9RLJ7VQxRD7YJgSuDFFqJShGLxjylOHlsVHg7BOsr7
Zd08j+v8LTRaKDHnKy5VccmA1JdL2RC19YC0vg4SzEjpwPVCDH9dhOAqNwhT3co=
=eITb
-----END PGP SIGNATURE-----