[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/3] target-arm: don't hardcode mask values in a
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH 1/3] target-arm: don't hardcode mask values in arm_cpu_handle_mmu_fault |
Date: |
Thu, 24 Jul 2014 17:10:15 +0100 |
On 24 July 2014 16:52, Alex Bennée <address@hidden> wrote:
> Otherwise we break quickly when we change TARGET_PAGE_SIZE.
>
> Signed-off-by: Alex Bennée <address@hidden>
>
> diff --git a/target-arm/helper.c b/target-arm/helper.c
> index a0e57cd..aa5d267 100644
> --- a/target-arm/helper.c
> +++ b/target-arm/helper.c
> @@ -4029,8 +4029,8 @@ int arm_cpu_handle_mmu_fault(CPUState *cs, vaddr
> address,
> &page_size);
> if (ret == 0) {
> /* Map a single [sub]page. */
> - phys_addr &= ~(hwaddr)0x3ff;
> - address &= ~(target_ulong)0x3ff;
> + phys_addr &= TARGET_PAGE_MASK;
> + address &= TARGET_PAGE_MASK;
> tlb_set_page(cs, address, phys_addr, prot, mmu_idx, page_size);
> return 0;
> }
Reviewed-by: Peter Maydell <address@hidden>
thanks
-- PMM