Re: [Qemu-devel] [PATCH 1/3] libqemustub: add qemu_system_shutdown_request() and no_shutdown

[Stefan Hajnoczi]

On Thu, Jul 24, 2014 at 6:07 PM, Peter Maydell <address@hidden> wrote:
> On 24 July 2014 17:39, Stefan Hajnoczi <address@hidden> wrote:
>> +++ b/stubs/shutdown.c
>> @@ -0,0 +1,7 @@
>> +#include "sysemu/sysemu.h"
>> +
>> +int no_shutdown;
>> +
>> +void qemu_system_shutdown_request(void)
>> +{
>> +}
>
> Tangential, but every use of "no_shutdown" outside vl.c
> is in the sequence:
>                 no_shutdown = 0;
>                 qemu_system_shutdown_request();
>
> so maybe we should have a
>    qemu_system_shutdown_demand();
> and make the no_shutdown variable private to vl.c ?
>
> (feel free to pick a better name :-))

Sure, I will find a solution for v2.

Stefan