Re: [Qemu-devel] [PATCH 2/7] tests: Add virtio device initialization

[Stefan Hajnoczi]

On Fri, Jul 25, 2014 at 07:01:47PM +0200, Marc Marí wrote:
> > > @@ -73,3 +97,11 @@ QVirtioPCIDevice
> > > *qvirtio_pci_device_find(QPCIBus *bus, uint16_t device_type) 
> > >      return dev;
> > >  }
> > > +
> > > +void qvirtio_pci_enable_device(QVirtioPCIDevice *d)
> > > +{
> > > +    qpci_device_enable(d->pdev);
> > > +    d->addr = qpci_iomap(d->pdev, 0);
> > > +    g_assert(d->addr != NULL);
> > > +}
> > 
> > Where is qpci_iounmap() called to clean up?
> 
> Missed. Also, it is unimplemented.

It would be much harder to add in the appropriate guest_free() calls
later so users should still call it.  Just like we should call
guest_free() even if it is currently unimplemented.

Stefan

pgp_VXr41kofD.pgp
Description: PGP signature