[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-2.2 2/2] qemu-nbd: add option to set detect-
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH for-2.2 2/2] qemu-nbd: add option to set detect-zeroes mode |
Date: |
Mon, 28 Jul 2014 14:01:40 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 |
On 07/28/2014 01:43 PM, Peter Lieven wrote:
> Signed-off-by: Peter Lieven <address@hidden>
> ---
> qemu-nbd.c | 81
> +++++++++++++++++++++++++++++++++++++++---------------------
> 1 file changed, 53 insertions(+), 28 deletions(-)
>
> @@ -57,45 +60,47 @@ static void usage(const char *name)
> "Usage: %s [OPTIONS] FILE\n"
> "QEMU Disk Network Block Device Server\n"
> "\n"
> -" -h, --help display this help and exit\n"
> -" -V, --version output version information and exit\n"
> +" -h, --help display this help and exit\n"
> +" -V, --version output version information and exit\n"
More than 50% of this patch is reformatting existing code to prepare for
new whitespace alignment. It makes it a bit harder to find the meat of
the patch; I might have split the realignment and the code additions
into separate commits. Not a reason for a respin by itself, but food
for thought if you do a v2.
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature